February 24, 2018 at 12:03 PM #19519marqsParticipant
@paulb_nl does the implementation set per-pixel mask intensity based on the original value alone, or does it need data from neighbor pixels? As for line-multiple specific adjustment feature, I haven’t had yet time to implement that but basically it’d just move selection logic (which sets V_SCANLINEID) to soft-CPU side where it can set more dynamically. You may want to check a pending pull request from borti4938 that adds another generation method and overall changes the code a bit.February 24, 2018 at 12:30 PM #19520Morpheus_79Participant
There’s a firmware test build for bortis scanline method available on his own github repository:February 24, 2018 at 4:05 PM #19526
From what I see the 0.79 scanlines are already hybrid, and the “scaline str. %” parameter controls from what IRE the scanlines will start to blend gradually.
ie. A setting of 25% will have not effect on IRE 25 and below so they will have 100% scalines, but will gradually brighten the black lines from 25 to 100 IRE.
Kind of looks like a simple linear equation where the slope is movable horizontally, as such:
The missing parameter is how quickly (slope) the filling of black lines occurs from the selected strength % parameter.
In that sense borti4938’s and paulb_nl’s final result is quite similar but differ at what point and how quickly the blending occurs.February 24, 2018 at 6:03 PM #19530
@marqs Yea basically its just subtracting the original value from the scanline strength so that high values have lower scanline strength. Thanks for the heads up about the pull request. I will check it out.
Here is the link to the test firmware for people that want to try it out. I left it running for 4 hours and there were no issues so it should be good. https://drive.google.com/file/d/1pNzelKMLYHA6E0KJgsj0f0Y34Bw9uQrO/view?usp=sharingFebruary 24, 2018 at 7:50 PM #19531
Playing with the contrast and strength setting and indeed the resulting gamma curve with the “Low” 87% setting is much closer to what a CRT looks than the standard Off setting at any strength,,, it’s all about the resulting gamma curve that looks nice or not.
It seems the High setting is much too much and not very useful below 100% strength and Low is also slightly too much when below 75%.
I think the sweet spot between Off and Low is missing.
paulb_nl can you try adding a setting between Off and Low? Maybe change Low to Medium and add another lower Low.
And maybe move the Contrast setting below Strength as they are work together to achieve the result.
My reference is a Sony Trinitron 29″ CRT with the lights off which looks beautiful.
I’m trying to achieve the same look on the OSSC with the new scanline settings.February 24, 2018 at 9:07 PM #19532
nice that you have implemented ‘hybrid scanlines’. 🙂
Would you mind to share the code on a new GitHub branch at this point of development? If you have the feeling that just fine-tuning has to be made, I would love to include that into the pull request; and make it user selectable such that each user can select the flavour he likes. I’ve added a menu point anyway to compare directly with the ‘old’ method.
Also, would you mind if I use your implementation in my N64 project?
BRFebruary 24, 2018 at 10:18 PM #19533
Hi @borti4938 Sure you can use it! Its not a very complex implementation anyway 😀 I have named it Scanline contrast for now. Here is the commit: https://github.com/paulb-nl/ossc/commit/990bc1563eef0a5650dabcc5633d3aeb562abc38
James-F wants a lower setting so I was thinking to add 50% Low alongside 62% Medium and 87% High.February 24, 2018 at 10:48 PM #19534
Cool – thank you 😉 That’s simple, indeed.
Will merge it soon at the begin of next week.
I’m thinking of adding it into the methods as Hybrid (low), Hybrid (med) and Hybrid (high) next to Multiplication and Subtraction in the “method” selection.February 25, 2018 at 1:33 AM #19537RetrorunnerParticipant
I have tested bortis scanlines and it looks better. Colors are much closer to the original value:
February 25, 2018 at 7:26 AM #19543
James-F wants a lower setting so I was thinking to add 50% Low alongside 62% Medium and 87% High.
Thanks, yes a lower setting than the current low is needed.
On the current Low setting the white color starts to have scanlines at 75%, and the resulting gamma is too high.
While Off (stock), white starts so have scanlines immediately, but the image appears to be flat (gamma too low).
A great way to look at the resulting gamma curve with scanlines is the “Grey Ramp” on the 240p suite.
Put Strength on 50% and flick between the Contrast settings.
February 25, 2018 at 12:56 PM #19546February 25, 2018 at 1:20 PM #19547
I made some notes and from principle it’s not a problem to make the ‘contrast’ value for hybrid scaliness freely available from 6.25% up to 100%. There are enough free multiplier units left in the FPGA.
Although I feel that it makes settings a bit too complicate for the casual user: “‘scanline strength’ and ‘contrast for hybrid scanlines’…??? Which one should I vary first???”February 25, 2018 at 1:31 PM #19549
Indeed I think it would make it too complicated. Also if you go too low with the contrast setting then the difference is not much noticable between Hybrid off and on. 50% is probably the best lowest setting.February 25, 2018 at 2:25 PM #19554
OK, my intuition, too. Then I will left it as is with the three presets and will left one bit as reserve.February 25, 2018 at 5:44 PM #19562RetrorunnerParticipant
Tested and I think we are on a good way but the main problem remains as with the standard scanlines (via substruction): the color level on dark surfaces is way to crushed and looks false (check the wall on the left).
I think the combination of bortis (scanlines via multiplication ) and hybrid scanlines would be near perfect – if possible.
- You must be logged in to reply to this topic.